ci: add optional praxis main testing and known-issue label#326
Open
leseb wants to merge 11 commits into
Open
Conversation
Add CI support for testing against praxis core main branch via workflow_dispatch input, and a praxis-known-issue PR label that allows jobs to pass despite failures from transient core issues. Signed-off-by: Sébastien Han <seb@redhat.com>
Contributor
Author
|
I'm opening this as a draft since i think it's valuable to test regularly against praxis main but would like inputs from other maintainers too - @franciscojavierarceo @aslakknutsen |
Remove the conditional gating so clone-praxis and patch-praxis steps run unconditionally. Rename the workflow_dispatch input from praxis_main (boolean) to praxis_ref (string) so manual runs can target a specific branch or tag. Signed-off-by: Sébastien Han <seb@redhat.com>
Move praxis-main testing into a dedicated workflow (praxis-compat.yaml) so regular CI stays on crates.io and the praxis-main job is visually distinct. The new test-praxis-main check is excluded from ci-status so it does not block PRs. Also make Config construction forward-compatible by using serde round-trip instead of struct literals, so new #[serde(default)] fields in praxis-core (like metrics) are handled automatically. Signed-off-by: Sébastien Han <seb@redhat.com>
Praxis core main added peer_identity, pre_read_mutations, and structured_metadata fields to HttpFilterContext. Use a praxis-main feature flag to conditionally include these fields in the test context constructors. The praxis-compat CI workflow passes --features praxis-main when running unit tests for apis and filters crates. Signed-off-by: Sébastien Han <seb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
praxis_mainworkflow_dispatch input to Tests and Integration workflows to optionally build/test against praxis coremainbranch instead of the crates.io release (uses[patch.crates-io]overrides)praxis-known-issuePR label support: when applied, jobs usecontinue-on-errorso transient praxis core failures don't block PRspatch-praxis/unpatch-praxisMakefile targets for local development against a sibling../praxischeckoutclone-praxiscomposite action with configurablerefinput and adds newpatch-praxiscomposite actionTest plan
praxis_main: trueon this branchpraxis-known-issuelabel and verify jobs report green on failuremake patch-praxislocally with../praxispresent, verify build